test: make testLoadFeatureFlagsWrongKey deterministic#127
Merged
marandaneto merged 1 commit intomainfrom Apr 20, 2026
Merged
Conversation
Previously relied on a live HTTPS request with a fake personal API key and expected the real server to return a response that triggered an exception. That is flaky: network reachability and server behavior vary across CI runs. Mock the local_evaluation endpoint to return a payload with a "detail" key so loadFlags() always throws. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Member
Author
|
this is blocking #126 - CI flakiness |
turnipdabeets
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously relied on a live HTTPS request with a fake personal API key and expected the real server to return a response that triggered an exception. That is flaky: network reachability and server behavior vary across CI runs. Mock the local_evaluation endpoint to return a payload with a "detail" key so loadFlags() always throws.
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
If releasing new changes
releaselabel to the PRbump-patch,bump-minor, orbump-major